Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: Refactor the arg fetching code #4331

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fmt: Refactor the arg fetching code #4331

merged 1 commit into from
Jan 30, 2020

Conversation

LemonBoy
Copy link
Contributor

  • Error out if the requested index is out-of-bound
  • Tidy-up all the arg-related variables in a struct

@LemonBoy
fmt: Refactor the arg fetching code
5cdfcbe 
* Error out if the requested index is out-of-bound
* Tidy-up all the arg-related variables in a struct
andrewrk
andrewrk reviewed Jan 30, 2020
View reviewed changes
lib/std/fmt.zig
comptime var specifier_start = 0;
comptime var specifier_end = 0;
comptime var options = FormatOptions{};
comptime var arg_state: struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, that's a really cool pattern

@andrewrk andrewrk merged commit d27678f into ziglang:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LemonBoy @andrewrk